Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm unit tests #6895

Merged
merged 8 commits into from
Dec 3, 2024
Merged

Helm unit tests #6895

merged 8 commits into from
Dec 3, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 3, 2024 •
edited
Loading

Proposed changes

Add Helm template unit tests

### Testing
Run tests

make test

Update snapshots

make test-update-snaps

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 3, 2024 09:19
@github-actions github-actions bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 3, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.15%. Comparing base (97055e4) to head (ceb47f9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6895   +/-   ##
=======================================
  Coverage   53.15%   53.15%           
=======================================
  Files          88       88           
  Lines       20396    20396           
=======================================
  Hits        10842    10842           
  Misses       9111     9111           
  Partials      443      443

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jjngx
jjngx reviewed Dec 3, 2024
View reviewed changes
charts/tests/helmunit_test.go Outdated Show resolved Hide resolved
vepatel
vepatel reviewed Dec 3, 2024
View reviewed changes
go.mod Show resolved Hide resolved
@vepatel
Copy link
Contributor

vepatel commented Dec 3, 2024

@pdabelf5 can we exclude tests/ from operator sync job?

jjngx
jjngx reviewed Dec 3, 2024
View reviewed changes
charts/tests/helmunit_test.go Outdated Show resolved Hide resolved
@pdabelf5
Copy link
Collaborator Author

pdabelf5 commented Dec 3, 2024

@pdabelf5 can we exclude tests/ from operator sync job?

The operator syncs the released chart, not the directory from NIC

@pdabelf5 pdabelf5 merged commit 79030b8 into main Dec 3, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the helm-unit-tests branch December 3, 2024 16:01
nginx-bot pushed a commit that referenced this pull request Dec 3, 2024
@pdabelf5 @web-flow
Helm unit tests (#6895)
ef1835b
@pdabelf5 pdabelf5 added tests Pull requests that update tests and removed dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@vepatel vepatel vepatel approved these changes

@j1m-ryan j1m-ryan j1m-ryan approved these changes

@oseoin oseoin oseoin approved these changes

@haywoodsh haywoodsh haywoodsh approved these changes

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pdabelf5 @vepatel @haywoodsh @oseoin @j1m-ryan @jjngx